Add support for APPENDUID response data #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is of interest, I'd be happy to add |
jonhoo
requested changes
Jul 14, 2022
Codecov Report
|
jonhoo
approved these changes
Jul 16, 2022
jonhoo
requested changes
Jul 16, 2022
|
Added a parse test much like the other one, I hope that's cool for now. I am happy to look into the integration tests, however I will be AFK for two weeks. |
jonhoo
reviewed
Jul 17, 2022
|
Looks like there's also now a conflict in |
If the `UIDPLUS` extension is supported, the server will reply to `APPEND` commands with the UID of the new message. This can even be a list of UIDs if the `MULTIAPPEND` extension is also supported. Make this information available to the user as the result of an `AppendCmd`. The added doc strings have links to the relevant RFCs. Related to jonhoo#131.
bitfehler
force-pushed
the
bitfehler/append-uid
branch
from
3d19be4
to
1732482
Compare
|
Sorry for the wait! I rebased on current master and added another test for the MULTIAPPEND response. I hope this is fine for this PR. I'll start looking into the integration tests to see if I can add some for all the stuff I added now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
UIDPLUSextension is supported, the server will reply toAPPENDcommands with the UID of the new message. This can even be alist of UIDs if the
MULTIAPPENDextension is also supported.Make this information available to the user as the result of an
AppendCmd. The added doc strings have links to the relevant RFCs.Related to #131.
This change is